Feat/add event testing #71
Conversation
tinkerer-shubh
force-pushed
the
feat/add-event-testing
branch
from
ce148ca to
890d936
Compare
|
@tinkerer-shubh thanks a lot for this! |
There was a problem hiding this comment.
Amazing, loved it!
My only suggestion would be:
- to not add new tests
burn_works()andmint_works()to Fungible tests. - we already have
burn_works()andmint_works(). - you can use this new utility in those tests, would suit the structure of this repo better that way
Thanks a lot for this utility, we will definitely use it!
|
@ozgunozerk Thanks for the feedback! I’ve updated the existing |
|
@tinkerer-shubh seems like cargo fmt is failing. Feel free to see which tests are run in the CI from the workflow file itself, or in |
@ozgunozerk Happy to contribute! I've made the requested changes—let me know if anything else needs tweaking. I also ran all the tests (had missed one earlier), so the checks should pass now. Thanks again for the review! 🙌 |
Fixes: #68
This PR enhances the test coverage for event emissions in the fungible token implementation. It adds comprehensive testing for event topics and data in the following test cases:
transfer_works(): Test transfer and mint eventsburn_works(): Test mint and burn eventsmint_works(): Test mint eventThe changes include:
EventAssertionutility for consistent event testingPR Checklist